Nest Ingredient Observers Inside Main Experiment Directory #1

decodyng · 2019-08-26T23:28:58Z

This PR:

Creates a "nest_ingredients" parameter on Experiment object
Passes the list of ingredients into the Run object created within experiment
For runs with a FileStorageObserver attached, and with the nest_ingredients flag set to true, iterate over ingredients and add to that ingredient a FileStorageObserver with a directory at /<ingredient_name> .

AdamGleave · 2019-08-29T10:32:39Z

sacred/run.py

@@ -334,8 +341,19 @@ def _emit_started(self):
            )
            if self._id is None:
                self._id = _id
+            if (
+                observer.__class__.__name__ == "FileStorageObserver"


More Pythonic: isinstance(observer, FileStorageObserver). That will also match subclasses, which is probably desirable, but if not can do observer.__class__ ==FileStorageObserver.

AdamGleave

Minor comment

decodyng added 3 commits July 26, 2019 16:25

Pretty hacky version of nested ingredients

799df2b

fix merge conflicts

69f4f9c

actually fix merge issues, black is weird

3b54c48

decodyng changed the title ~~Nest Ingredients Directory~~ Nest Ingredient Observers Inside Main Experiment Directory Aug 26, 2019

AdamGleave reviewed Aug 29, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nest Ingredient Observers Inside Main Experiment Directory #1

Nest Ingredient Observers Inside Main Experiment Directory #1

decodyng commented Aug 26, 2019

AdamGleave Aug 29, 2019

AdamGleave left a comment

Nest Ingredient Observers Inside Main Experiment Directory #1

Are you sure you want to change the base?

Nest Ingredient Observers Inside Main Experiment Directory #1

Conversation

decodyng commented Aug 26, 2019

AdamGleave Aug 29, 2019

Choose a reason for hiding this comment

AdamGleave left a comment

Choose a reason for hiding this comment