You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
(check all that apply)
Product design
Backend (Database)
Backend (API)
Frontend
Describe the reason for change
When pausing playback of video, it does not currently land on a whole frame and is often de-synced from the frame boundary when the time it is paused on is too granular. Related: #7027
bmartel
changed the title
fix: OPTIC-1677: Video frame is misaligned when pausing playback
fix: OPTIC-1677: Incorrect video frame rendered when pausing a video during playback
Feb 13, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bmartel
changed the title
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
When pausing playback of video, it does not currently land on a whole frame and is often de-synced from the frame boundary when the time it is paused on is too granular. Related: #7027
What does this fix?
Closes #7050
What is the new behavior?
When video pauses it will set currentTime to an adjusted time that will land directly on a whole frame.
What is the current behavior?
Pauses and leaves an exact currentTime.
What feature flags were used to cover this change?
fflag_fix_front_optic_1608_improve_video_frame_seek_precision_shortDoes this PR introduce a breaking change?
(check only one)
Which logical domain(s) does this change affect?
Video