-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine components under Localisation namespace by language rather than by component type #206
Comments
Related to #59 |
@hazzik, I looked into your issue-206 branch, it looks like you already finished this. Is there something else that needs to be done or are we just waiting for V2? |
just waiting |
There were a few confusions are how we wanted to do it. IIRC we couldn't find a win-win situation and there was always a compromise. I am still not 100% convinced which way is better tbh. The PR will also have to be updated with the later localisation additions. |
Is this still in scope for v2? I'd like to get a beta out by the end of the month as the current dev branch adds CoreCLR support. |
When we were discussing this solution layout, I have very vague recollection but from the memory some things didn't quite fit into the proposed solution. Not that they do in the current structure but I guess my point is that this solved one problem and introduced another one. So I'm torn on it. I'd vote to keep it as is if we don't have a strong argument for this structure. Thoughts? |
I don't have any strong thoughts on this. There's something to be said for both sides. As far as I can see, aside from the interfaces/abstract base classes, the actual localization implementations are all internal, so moving it around should not be a breaking change. |
I'm closing this out, leaving things as-is for now. We can revisit if there's reason to later. |
etc
The text was updated successfully, but these errors were encountered: