-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Spanish localization #1172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinal converters.
clairernovotny
requested changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all of this. It looks really good. Just a couple of small things and I can merge it in!
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
src/Humanizer/Localisation/NumberToWords/SpanishNumberToWordsConverter.cs
Outdated
Show resolved
Hide resolved
Thank you for all of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve and fixes Spanish localization including ordinalizers, number to words converter, TimeSpan humanizer, time to clock notation and date to words converters.
Issues
fixes #1166
fixes #1168
fixes #1169
Checklist:
main
branch (more info below)fixes #<the issue number>
build.cmd
orbuild.ps1
and ensure there are no test failures (See below)Code analysis warning
Checked with ReSharper command line tools. Removed warnings on files modified by this PR.
Code coverage
All tests passed