Handle hyphenation and large numbers ending in twelve for English ordinal words #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to any grammatical reference I can find, ordinal numbers should be hyphenated in English following the same rules that cardinal numbers are. Additionally, I noticed that e.g. 112 was being ordinalized as "one hundred and ten second."
I opted to merge the code paths for these to avoid duplication of logic - in particular, respecting the rules for hyphenation of ordinals requires context about the rest of the number that wasn't available. Added a test for an ordinal ending in 12 and a cardinal multiple of ten.
I've also never used Git or Github before, so bear with me as I don't really know what I'm doing.