Added ToQuantity - issue #32 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static string ToQuantity(this string input, int quantity) | ||
| { | ||
| if (quantity == 1) | ||
| return string.Format("{0} {1}", quantity, input); |
There was a problem hiding this comment.
I think we need to call .Singularize on input, don't we?
There was a problem hiding this comment.
Hmmm, so you think "requests".ToQuantity(1) should return "1 request"? That's a nice observation. I kinda like this. Will add in.
Thanks for the review.
There was a problem hiding this comment.
Do'h. It turns out there is a bug in Singularize method where calling it on a singular word returns null. Similar bug exists on pluralize where calling pluralize on a plural word returns null or the word postfixed with an s; e.g. men => mens!
There was a problem hiding this comment.
This issue should be fixed but #43. I would really appreciate your review.
MehdiK
added a commit
that referenced
this pull request
Dec 30, 2013
Added ToQuantity - fixes issue #32
This was referenced Dec 31, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.