Added Ukrainian Language #411
Conversation
| @@ -82,8 +82,8 @@ public void TimeSpanWithMaxTimeUnit(int ms, string expected, TimeUnit maxUnit) | |||
| } | |||
|
|
|||
| [Theory] | |||
| [InlineData(0, 3, "no time")] | |||
There was a problem hiding this comment.
Any reasons why you have changed "no time" to "just now"? I'm asking because this can be used with general time-spans, which are not bound to any particular momentum.
There was a problem hiding this comment.
This was intended for cases when for example a post is just added and time span is 0 milliseconds so it would make sense to show 'just now'
But for what I understand from your comment sometimes users just want to translate such a time span to 'no time'
Would you like me to revert it back?
There was a problem hiding this comment.
Yes please revert these changes. We can open separate issue for "no time"/"just now" and discuss there.
|
Resources and tests are reverted to 'no time' |
| internal class UkrainianFormatter : DefaultFormatter | ||
| { | ||
| public UkrainianFormatter() | ||
| : base("uk-UA") |
|
I tried but in that case it loads default resources |
|
You should also rename |
|
I see. Will do so. |
|
Locale code updated |
| @@ -245,6 +245,10 @@ public class In | |||
|
|
|||
| public class InflectorExtensions | |||
| { | |||
| public void AddIrregular(string singular, string plural) { } | |||
There was a problem hiding this comment.
I think something gone wrong with the rebase, as this methods are part of another PR.
|
@hazzik Besides the comments, LGTM |
This reverts commit ca96ffa.
|
Reverted changes. |
| } |
|
@dmytro-ielkin Ok, now the hardest part. Please squash your pull request and rebase it on master. Also add your PR to the release_notes.md You can find more info in CONTRIBUTING.md |
This reverts commit ca96ffa.
…402 (comment)" This reverts commit 053ab63.
|
Ok. I was wrong to work on this PR in master. Will remove the repository and do it the right way. |
Hi,
I have added Ukrainian resources for datetime and timespan humanization as well as ordinazer, number to words converter. I don't have ReSharper so I hope there aren't any issues with that.
If there are feel free to let me know.
I'm using Humanizer in production website and looking forward to using updated nugget package when ready.
Regards,
Dmytro IELKIN