React Native Example Part 1 (ios) #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twitchard
force-pushed
the
richard/react-native-example
branch
from
f944e44 to
e276081
Compare
twitchard
force-pushed
the
richard/react-native-example
branch
from
e276081 to
cb8d37a
Compare
twitchard
force-pushed
the
richard/react-native-example
branch
from
40bca60 to
13b250e
Compare
twitchard
changed the title
twitchard
force-pushed
the
richard/react-native-example
branch
from
9b4eb91 to
27d1ce0
Compare
garrettbo
approved these changes
Nov 20, 2024
chrismanahan
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial PR includes a working ios app in React Native.
I couldn't find a suitable React Native library to do audio recording or playback, for instance expo-av doesn't support streaming (or echo cancellation). So the idea is to include audio handling Swift code in the example that gets the job done (via an expo module). The Swift code isn't comprehensive and doesn't handle e.g. audio device selection, or rarer cases like "the user connects a new audio device halfway through", but the idea is for the Swift code to be simple and readable enough for it to be a good starting place for users on React Native.
Inspired by the code in the (private) swift SDK and our own consumer app module.
I think this is the first public example code we have in Swift, too, so until there's another example (probably around the time we make the Swift SDK public?) this will be the best reference for anybody integrating EVI on ios.
https://www.loom.com/share/a4fbafc33e174cef845c7b1d46c630ed?sid=405503a2-f879-445d-919e-f0c29cbe18e0