Zg/update evi ts example #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks great and functions well!
2 points for consideration prior to approval:
- the latest version of the TypeScript SDK is now 0.8.3, whereas this example uses 0.8.1. It works with 0.8.3, and so the package.json and pnpm-lock.yaml may be updated and regenerated respectively
- Users may benefit from the VITE_HUME_CONFIG_ID being mentioned in the README, since it is a new environment variable, with a statement clarifying that the acceptable values include an empty string, or a valid EVI config id - and not the default value of "YOUR_CONFIG_ID"
…s example project readme
norman-codes
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
0.8.1) and refactors the code to utilize the breaking changes.