Skip to content

Commit

Permalink
Revert "fix compile"
Browse files Browse the repository at this point in the history
This reverts commit 6a54481.
  • Loading branch information
dsinghvi committed Oct 30, 2023
1 parent 6a54481 commit 4e20f6f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/wrapper/HumeBatchClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Job } from "./Job";

export class HumeBatchClient extends FernClient {
public async submitJob(request: Hume.BaseRequest = {}): Promise<Job> {

Check failure on line 6 in src/wrapper/HumeBatchClient.ts

View workflow job for this annotation

GitHub Actions / compile

Property 'submitJob' in type 'HumeBatchClient' is not assignable to the same property in base type 'HumeClient'.
const { job_id } = await super.submitJob(request);
const { jobId } = await super.submitJob(request);

Check failure on line 7 in src/wrapper/HumeBatchClient.ts

View workflow job for this annotation

GitHub Actions / compile

Property 'jobId' does not exist on type 'JobId'.
return new Job(jobId, this);
}
}
17 changes: 0 additions & 17 deletions src/wrapper/HumeStreamClient.ts

This file was deleted.

7 changes: 5 additions & 2 deletions src/wrapper/Job.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { createWriteStream } from "fs";
import { writeFile } from "fs/promises";
import { pipeline } from "stream/promises";
import * as Hume from "../api";
import * as errors from "../errors";
import { HumeBatchClient } from "./HumeBatchClient";

export class Job implements Hume.JobId {

Check failure on line 8 in src/wrapper/Job.ts

View workflow job for this annotation

GitHub Actions / compile

Class 'Job' incorrectly implements interface 'JobId'.
constructor(public readonly job_id: string, private readonly client: HumeBatchClient) {}
constructor(public readonly jobId: string, private readonly client: HumeBatchClient) {}

public async awaitCompletion(timeoutInSeconds = 300): Promise<void> {
return new Promise((resolve, reject) => {
const poller = new JobCompletionPoller(this.job_id, this.client);
const poller = new JobCompletionPoller(this.jobId, this.client);
poller.start(resolve);
setTimeout(() => {
poller.stop();
Expand Down

0 comments on commit 4e20f6f

Please sign in to comment.