Timer fix #63
Merged
Timer fix #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the split mechanic into even chunks: When the SpeedFaktor reaches the threshold (0.3), it is split: 0.4 was split into (1) 0.3 and (2) 0.1 Now it is split into two even steps.
The TimerClass had a local `SpeedFaktor` variable, which is used by the sync function. This leads to a desync between the local and the global variable and can cause the game speed to be calculated wrong. Example: The game speeds up when it runs with a low framerate (the speed factor is changed to have more accurate calculations, but the sync function still uses the "old" variable) This can be easily repuduced by starting the game in debug mode and typing ``` maxfps 10 ``` in the console to limit the framerate.
|
Didn't dig deep in the changes but I can see the vast improvement in 10 FPS mode and no regression in full FPS. As a further step I think it would be possible to move SpeedFaktor and its logic into the Timer class, all those global vars are quite annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the game speed calculation (see commit messages).
Steps to reproduce the bug:
Start the game (compiled in debug mode) and enter the command
into the console.
I also changed the mechanic, which splits the physic calculations into multiple steps,
when the game runs with a low framerate. The game speed is now even between
these steps.
Please let me know if there is a good reason for the chunks to not be even.