Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port waybar weather module pr from hyprdots #19

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

boulder-roller
Copy link
Contributor

@boulder-roller boulder-roller commented Dec 13, 2024

Port of prasanthrangan/hyprdots#1192

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

@kRHYME7
Copy link
Contributor

kRHYME7 commented Dec 13, 2024

We should further look into this. 2 external dependencies are too much IMO.

Let's hold this PR for a while.

@boulder-roller
Copy link
Contributor Author

@kRHYME7 only one of them is actually used atm (python-requests), but in the original pr it was recommended to use the other, the script just hasn't been updated to include that yet.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Dec 14, 2024

@boulder-roller Will merge this now. But there will be changes

Also, I think I should rename the "custom_hypr.lst : and "custom_app.lst ", it's confusing.
cutsom_hypr.lst are the core apps and custom_apps.lst are optional.

renaming it into pkg_custom.lst and pkg_core.lst

@kRHYME7 kRHYME7 merged commit 6e10654 into HyDE-Project:master Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants