Update examples to work with Hydrosphere~=2.4.0 #51
Conversation
| - `models` — Folder contains model artifacts, ready to be uploaded to the Hydrosphere. | ||
| - `ops` — Folder contains models' training script. | ||
|
|
||
| ## Prerequisites |
There was a problem hiding this comment.
Don't you think it will be better to move Prerequisites to main README?
| hs cluster use local | ||
| ``` | ||
|
|
||
| ## Model upload |
There was a problem hiding this comment.
Maybe we should add reminder to pull all data from dvc? Often people forget about this step in main README
|
|
||
| cluster = Cluster( | ||
| http_address="<hydrosphere-http-address>", | ||
| grpc_address="<hydrosphere-grpc-address>", |
There was a problem hiding this comment.
I think we should clarify where user can get grpc address
| install-command: "pip install -r requirements.txt" | ||
| payload: | ||
| - "src/" | ||
| - "requirements.txt" |
There was a problem hiding this comment.
Can we have one file with requirements.txt for model and demo?
| @@ -0,0 +1,4 @@ | |||
| numpy==1.16.2 | |||
There was a problem hiding this comment.
demo folder has no requirements. Maybe it is better to move requirements to root model folder and remind about their installation in model/README.md?
| @@ -0,0 +1,72 @@ | |||
| from hydrosdk import Cluster, ModelVersion, LocalModel, DockerImage, SignatureBuilder | |||
There was a problem hiding this comment.
Maybe we should also leave an example of serving.yaml with monitoring and with application creation and how to use hs apply
No description provided.