Skip to content

Commit

Permalink
Feature/hyperfine 1.7 (#3)
Browse files Browse the repository at this point in the history
* Update website links to v1.6.1 (awslabs#487)

Update website links to v1.6.1

* Update git clone command (awslabs#488)

Update git clone command

* Katib S3-only Helm Path cherrypick (awslabs#507)

Cherry pick the helm path installation config fix for s3-only
deployment.

Co-authored-by: Pei Ran Li <prli@users.noreply.github.com>

* Cherry-pick Kserve with IRSA and Notebook culling Doc (awslabs#512)

* Cherry-pick Kserve with IRSA and Notebook culling Doc into v1.6.1
release

* Cherrypick: Add permission configuration steps to SageMaker KFP docs (awslabs#506) (awslabs#528)

**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**

- Adds required permission steps for using Sagemaker v1/v2 integration
with KFP

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* New blog/workshop update - 1.6 (awslabs#533)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* docsearch backport 1.6 (awslabs#534)

docsearch first integration
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* 1.6

* helm provider

* blueprints

* fix oidc

* Cherry-Pick terraform bug fixes (awslabs#590)

**Which issue is resolved by this Pull Request:**
**Description of your changes:**
Update RDS version
awslabs#584
Update AWS blueprints - gpu bug
awslabs#516

**Testing:**
Cognito-rds-s3 passed `6 passed, 13 warnings in 4594.63s (1:16:34)`
rds-s3 passed `7 passed, 49 warnings in 4490.15s (1:14:50)`

- [ ] Unit tests pass
- [x] e2e tests pass

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Shadab Hussain <shadab.entrepreneur@outlook.com>
Co-authored-by: Gerhard Häring <gh@ghaering.de>

* Updating website to reflect latest version (awslabs#596)

**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**


**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Ubuntu <ubuntu@ip-172-31-58-39.us-west-2.compute.internal>

* Cherry pick sagemaker fix and move of kfp SM test (awslabs#619)

**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**
Cherry pick sagemaker fix and move of kfp SM test

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* fix secrets

* [Cherry pick] Change Dex Service from Nodeport to ClusterIP (awslabs#630)

**Description of your changes:**
There are occasional times when installing dex we see the following
error message:
```
The Service "dex" is invalid: spec.ports[0].nodePort: Invalid value: 32000: provided port is already allocated
```

It indicates that there is already a service using port 32000 on the
same node trying to create the "dex" service.
Dex service was modified to be exposed as ClusterIP instead of NodePort
in the new release KF v1.7.0 along with Istio for security upgrade
(kubeflow/manifests#2357)

This is a mirror patch from the above PR to change Dex service from
NodePort to ClusterIP to solve the error message seen.



**Testing:**
- [ ] Unit tests pass
- [x] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* [Cherry-Pick] increase cert-manager wait time for kubeflow-issuer to be install (awslabs#632)

Cherry pick this commit from main to temporarily solve:
```
: Internal error occurred: failed calling webhook "webhook.cert-manager.io": failed to call webhook: Post "[https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=10s](https://cert-manager-webhook.cert-manager.svc/mutate?timeout=10s)": context deadline exceeded
```

* variables

* [Cherry Pick] Enable canary report generation (awslabs#634)

-enable canary report generation after each canary run.

* Update blog content (awslabs#638)

**Description of your changes:**
- Remove Trainium (pending future release)
- Update link to AWS Docs (was localhost)
- Update ordered list numbering

**Testing:**
- Tested local Hugo build

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: Suraj Kota <surakota@amazon.com>

* add pipeline pd

* [Cherry-pick] Push Canary Success Rate to Cloudwatch Metric (awslabs#662)

- cherry-pick pushing success_rate into cloudwatch metrics

* Release v1.6.1 aws b1.0.2 (awslabs#666)

**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**

Note: As a result of the depreciation of k8s.gcr.io, images have moved
to registry.k8s.io. This only effects csi-secrets-driver for those who
have installed either RDS-S3/Cognito-RDS-S3. To update your pulled image
source run the following kubectl commands

```
kubectl set image daemonset/csi-secrets-store node-driver-registrar=registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.3.0 -n kube-system
kubectl set image daemonset/csi-secrets-store secrets-store=registry.k8s.io/csi-secrets-store/driver:v1.0.0-rc.1 -n kube-system
kubectl set image daemonset/csi-secrets-store liveness-probe=registry.k8s.io/sig-storage/livenessprobe:v2.4.0 -n kube-system
```

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* update website to release-v1.6.1-aws-b1.0.2 (awslabs#667)

**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**
Points toml and documentation to latest release version

**Testing:**
- [ ] Unit tests pass
- [ ] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* Update config.toml for v1.6.1 (awslabs#705)

- change version from `latest` to `1.6`

* [Cherry pick] Kserve Indentation doc fix v1.6.1 (awslabs#721)

- cherry-pick for this PR
awslabs#719
- Keep empty AWS credential strings

* fix evictions

* value needed for defaults

* Website changes for release branch (awslabs#758)

**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**
- Same as title

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

* refactor
---------

Co-authored-by: Kartik Kalamadi <kalamadi@amazon.com>
Co-authored-by: jsitu777 <59303945+jsitu777@users.noreply.github.com>
Co-authored-by: Pei Ran Li <prli@users.noreply.github.com>
Co-authored-by: ryansteakley <37981995+ryansteakley@users.noreply.github.com>
Co-authored-by: Nadege PEPIN <5490706+npepin-hub@users.noreply.github.com>
Co-authored-by: ananth102 <abashyam@amazon.com>
Co-authored-by: Shadab Hussain <shadab.entrepreneur@outlook.com>
Co-authored-by: Gerhard Häring <gh@ghaering.de>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-58-39.us-west-2.compute.internal>
Co-authored-by: Kevin Hoyt <parkerkrhoyt@gmail.com>
Co-authored-by: Suraj Kota <surakota@amazon.com>
  • Loading branch information
12 people committed Jun 15, 2023
1 parent 39e8e90 commit d4e0a1d
Show file tree
Hide file tree
Showing 61 changed files with 2,201 additions and 119 deletions.
9 changes: 9 additions & 0 deletions awsconfigs/common/dex/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: auth
bases:
- ../../../upstream/common/dex/overlays/istio

patchesStrategicMerge:
- patches/service.yaml
- patches/disable-nodeport.yaml
11 changes: 11 additions & 0 deletions awsconfigs/common/dex/patches/disable-nodeport.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: v1
kind: Service
metadata:
name: dex
spec:
ports:
- name: dex
port: 5556
protocol: TCP
targetPort: 5556
nodePort: null
6 changes: 6 additions & 0 deletions awsconfigs/common/dex/patches/service.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: v1
kind: Service
metadata:
name: dex
spec:
type: ClusterIP
2 changes: 1 addition & 1 deletion charts/apps/jupyter-web-app/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ appVersion: v1.7.0
description: A Helm chart for Kubernetes
name: jupyter-web-app
type: application
version: 0.2.0
version: 0.2.2
Original file line number Diff line number Diff line change
@@ -1,95 +1,11 @@
apiVersion: v1
data:
spawner_ui_config.yaml: "# Configuration file for the Jupyter UI.\n#\n# Each Jupyter\
\ UI option is configured by two keys: 'value' and 'readOnly'\n# - The 'value'\
\ key contains the default value\n# - The 'readOnly' key determines if the option\
\ will be available to users\n#\n# If the 'readOnly' key is present and set to\
\ 'true', the respective option\n# will be disabled for users and only set by\
\ the admin. Also when a\n# Notebook is POSTED to the API if a necessary field\
\ is not present then\n# the value from the config will be used.\n#\n# If the\
\ 'readOnly' key is missing (defaults to 'false'), the respective option\n# will\
\ be available for users to edit.\n#\n# Note that some values can be templated.\
\ Such values are the names of the\n# Volumes as well as their StorageClass\n\
spawnerFormDefaults:\n image:\n # The container Image for the user's Jupyter\
\ Notebook\n value: public.ecr.aws/kubeflow-on-aws/notebook-servers/jupyter-tensorflow:2.12.0-cpu-py310-ubuntu20.04-ec2-v1.0\n\
\ # The list of available standard container Images\n options:\n - kubeflownotebookswg/jupyter-scipy:v1.7.0\n\
\ - public.ecr.aws/kubeflow-on-aws/notebook-servers/jupyter-tensorflow:2.12.0-gpu-py310-cu118-ubuntu20.04-ec2-v1.0\n\
\ - public.ecr.aws/kubeflow-on-aws/notebook-servers/jupyter-tensorflow:2.12.0-cpu-py310-ubuntu20.04-ec2-v1.0\n\
\ - public.ecr.aws/kubeflow-on-aws/notebook-servers/jupyter-pytorch:2.0.0-gpu-py310-cu118-ubuntu20.04-ec2-v1.0\n\
\ - public.ecr.aws/kubeflow-on-aws/notebook-servers/jupyter-pytorch:2.0.0-cpu-py310-ubuntu20.04-ec2-v1.0\n\
\ imageGroupOne:\n # The container Image for the user's Group One Server\n\
\ # The annotation `notebooks.kubeflow.org/http-rewrite-uri: /`\n # is applied\
\ to notebook in this group, configuring\n # the Istio rewrite for containers\
\ that host their web UI at `/`\n value: kubeflownotebookswg/codeserver-python:v1.7.0\n\
\ # The list of available standard container Images\n options:\n - kubeflownotebookswg/codeserver-python:v1.7.0\n\
\ imageGroupTwo:\n # The container Image for the user's Group Two Server\n\
\ # The annotation `notebooks.kubeflow.org/http-rewrite-uri: /`\n # is applied\
\ to notebook in this group, configuring\n # the Istio rewrite for containers\
\ that host their web UI at `/`\n # The annotation `notebooks.kubeflow.org/http-headers-request-set`\n\
\ # is applied to notebook in this group, configuring Istio\n # to add the\
\ `X-RStudio-Root-Path` header to requests\n value: kubeflownotebookswg/rstudio-tidyverse:v1.7.0\n\
\ # The list of available standard container Images\n options:\n - kubeflownotebookswg/rstudio-tidyverse:v1.7.0\n\
\ # If true, hide registry and/or tag name in the image selection dropdown\n\
\ hideRegistry: true\n hideTag: false\n allowCustomImage: true\n # If true,\
\ users can input custom images\n # If false, users can only select from the\
\ images in this config\n imagePullPolicy:\n # Supported values: Always, IfNotPresent,\
\ Never\n value: IfNotPresent\n readOnly: false\n cpu:\n # CPU for user's\
\ Notebook\n value: '0.5'\n # Factor by with to multiply request to calculate\
\ limit\n # if no limit is set, to disable set \"none\"\n limitFactor: \"\
1.2\"\n readOnly: false\n memory:\n # Memory for user's Notebook\n value:\
\ 1.0Gi\n # Factor by with to multiply request to calculate limit\n # if\
\ no limit is set, to disable set \"none\"\n limitFactor: \"1.2\"\n readOnly:\
\ false\n environment:\n value: {}\n readOnly: false\n workspaceVolume:\n\
\ # Workspace Volume to be attached to user's Notebook\n # If you don't\
\ want a workspace volume then delete the 'value' key\n value:\n mount:\
\ /home/jovyan\n newPvc:\n metadata:\n name: '{notebook-name}-workspace'\n\
\ spec:\n resources:\n requests:\n storage:\
\ 10Gi\n accessModes:\n - ReadWriteOnce\n readOnly: false\n\
\ dataVolumes:\n # List of additional Data Volumes to be attached to the user's\
\ Notebook\n value: []\n # For example, a list with 2 Data Volumes:\n \
\ # value:\n # - mount: /home/jovyan/datavol-1\n # newPvc:\n #\
\ metadata:\n # name: '{notebook-name}-datavol-1'\n # \
\ spec:\n # resources:\n # requests:\n # \
\ storage: 5Gi\n # accessModes:\n # - ReadWriteOnce\n\
\ # - mount: /home/jovyan/datavol-1\n # existingSource:\n # \
\ persistentVolumeClaim:\n # claimName: test-pvc\n readOnly:\
\ false\n gpus:\n # Number of GPUs to be assigned to the Notebook Container\n\
\ value:\n # values: \"none\", \"1\", \"2\", \"4\", \"8\"\n num:\
\ \"none\"\n # Determines what the UI will show and send to the backend\n\
\ vendors:\n - limitsKey: \"nvidia.com/gpu\"\n uiName: \"NVIDIA\"\
\n - limitsKey: \"amd.com/gpu\"\n uiName: \"AMD\"\n # Values:\
\ \"\" or a `limits-key` from the vendors list\n vendor: \"\"\n readOnly:\
\ false\n affinityConfig:\n # If readonly, the default value will be the only\
\ option\n # value is a list of `configKey`s that we want to be selected by\
\ default\n value: \"\"\n # The list of available affinity configs\n \
\ options: []\n #options:\n # - configKey: \"exclusive__n1-standard-2\"\
\n # displayName: \"Exclusive: n1-standard-2\"\n # affinity:\n \
\ # # (Require) Node having label: `node_pool=notebook-n1-standard-2`\n \
\ # nodeAffinity:\n # requiredDuringSchedulingIgnoredDuringExecution:\n\
\ # nodeSelectorTerms:\n # - matchExpressions:\n \
\ # - key: \"node_pool\"\n # operator: \"In\"\
\n # values:\n # - \"notebook-n1-standard-2\"\
\n # # (Require) Node WITHOUT existing Pod having label: `notebook-name`\n\
\ # podAntiAffinity:\n # requiredDuringSchedulingIgnoredDuringExecution:\n\
\ # - labelSelector:\n # matchExpressions:\n #\
\ - key: \"notebook-name\"\n # operator: \"\
Exists\"\n # namespaces: []\n # topologyKey: \"kubernetes.io/hostname\"\
\n #readOnly: false\n tolerationGroup:\n # The default `groupKey` from\
\ the options list\n # If readonly, the default value will be the only option\n\
\ value: \"\"\n # The list of available tolerationGroup configs\n options:\
\ []\n #options:\n # - groupKey: \"group_1\"\n # displayName: \"\
Group 1: description\"\n # tolerations:\n # - key: \"key1\"\n \
\ # operator: \"Equal\"\n # value: \"value1\"\n # \
\ effect: \"NoSchedule\"\n # - key: \"key2\"\n # operator: \"\
Equal\"\n # value: \"value2\"\n # effect: \"NoSchedule\"\n\
\ readOnly: false\n shm:\n value: true\n readOnly: false\n configurations:\n\
\ # List of labels to be selected, these are the labels from PodDefaults\n\
\ # value:\n # - add-aws-secret\n # - default-editor\n value:\
\ []\n readOnly: false\n"
spawner_ui_config.yaml: {{- .Values.spawner_ui_config | toYaml | indent 2 }}
kind: ConfigMap
metadata:
annotations: {}
labels:
app: jupyter-web-app
kustomize.component: jupyter-web-app
name: jupyter-web-app-config-mgf762gt24
namespace: kubeflow
namespace: kubeflow
156 changes: 154 additions & 2 deletions charts/apps/jupyter-web-app/values.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,154 @@
null
...
spawner_ui_config: |
spawnerFormDefaults:
image:
# The container Image for the user's Jupyter Notebook
value: 369500102003.dkr.ecr.us-east-1.amazonaws.com/dl-research:jupyter-f932cdf
# The list of available standard container Images
options:
- 369500102003.dkr.ecr.us-east-1.amazonaws.com/dl-research:jupyter-f932cdf
- kubeflownotebookswg/jupyter-pytorch-full:v1.6.1
- kubeflownotebookswg/jupyter-pytorch-cuda-full:v1.6.1
- kubeflownotebookswg/jupyter-tensorflow-full:v1.6.1
- kubeflownotebookswg/jupyter-tensorflow-cuda-full:v1.6.1
imageGroupOne:
# The container Image for the user's Group One Server
# The annotation `notebooks.kubeflow.org/http-rewrite-uri: /`
# is applied to notebook in this group, configuring
# the Istio rewrite for containers that host their web UI at `/`
value: 369500102003.dkr.ecr.us-east-1.amazonaws.com/dl-research:vscode-f932cdf
# The list of available standard container Images
options:
- 369500102003.dkr.ecr.us-east-1.amazonaws.com/dl-research:vscode-f932cdf
imageGroupTwo:
# The container Image for the user's Group Two Server
# The annotation `notebooks.kubeflow.org/http-rewrite-uri: /`
# is applied to notebook in this group, configuring
# the Istio rewrite for containers that host their web UI at `/`
# The annotation `notebooks.kubeflow.org/http-headers-request-set`
# is applied to notebook in this group, configuring Istio
# to add the `X-RStudio-Root-Path` header to requests
value: kubeflownotebookswg/rstudio-tidyverse:v1.6.1
# The list of available standard container Images
options:
- kubeflownotebookswg/rstudio-tidyverse:v1.6.1
# If true, hide registry and/or tag name in the image selection dropdown
hideRegistry: false
hideTag: false
allowCustomImage: true
# If true, users can input custom images
# If false, users can only select from the images in this config
imagePullPolicy:
# Supported values: Always, IfNotPresent, Never
value: IfNotPresent
readOnly: false
cpu:
# CPU for user's Notebook
value: '0.5'
# Factor by with to multiply request to calculate limit
# if no limit is set, to disable set "none"
limitFactor: "1.2"
readOnly: false
memory:
# Memory for user's Notebook
value: 1.0Gi
# Factor by with to multiply request to calculate limit
# if no limit is set, to disable set "none"
limitFactor: "1.2"
readOnly: false
environment:
value: {}
readOnly: false
workspaceVolume:
# Workspace Volume to be attached to user's Notebook
# If you don't want a workspace volume then delete the 'value' key
value:
# mount: /home/dl-user
# existingSource:
# persistentVolumeClaim:
# claimName: '-home'
readOnly: false
dataVolumes:
value:
- mount: /data
newPvc:
metadata:
name: '{notebook-name}-vol-1'
spec:
resources:
requests:
storage: 30Gi
accessModes:
- ReadWriteOnce
readOnly: false
gpus:
# Number of GPUs to be assigned to the Notebook Container
value:
# values: "none", "1", "2", "4", "8"
num: "none"
# Determines what the UI will show and send to the backend
vendors:
- limitsKey: "nvidia.com/gpu"
uiName: "NVIDIA"
# - limitsKey: "amd.com/gpu"
# uiName: "AMD"
# Values: "" or a `limits-key` from the vendors list
vendor: ""
readOnly: false
affinityConfig:
# If readonly, the default value will be the only option
# value is a list of `configKey`s that we want to be selected by default
value: ""
# The list of available affinity configs
options: []
#options:
# - configKey: "exclusive__n1-standard-2"
# displayName: "Exclusive: n1-standard-2"
# affinity:
# # (Require) Node having label: `node_pool=notebook-n1-standard-2`
# nodeAffinity:
# requiredDuringSchedulingIgnoredDuringExecution:
# nodeSelectorTerms:
# - matchExpressions:
# - key: "node_pool"
# operator: "In"
# values:
# - "notebook-n1-standard-2"
# # (Require) Node WITHOUT existing Pod having label: `notebook-name`
# podAntiAffinity:
# requiredDuringSchedulingIgnoredDuringExecution:
# - labelSelector:
# matchExpressions:
# - key: "notebook-name"
# operator: "Exists"
# namespaces: []
# topologyKey: "kubernetes.io/hostname"
#readOnly: false
tolerationGroup:
# The default `groupKey` from the options list
# If readonly, the default value will be the only option
value: ""
options:
- groupKey: "gpu"
displayName: "gpu toleration"
tolerations:
- key: "nvidia.com/gpu"
operator: "Equal"
value: "true"
effect: "PreferNoSchedule"
- groupKey: "spot"
displayName: "spot toleration"
tolerations:
- key: "spot"
operator: "Equal"
value: "true"
effect: "NoSchedule"
shm:
value: true
readOnly: false
configurations:
value:
- add-secret-volume
- add-env
- prevent-eviction
- access-ml-pipeline
readOnly: false
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
annotations:
"helm.sh/hook": "pre-install"
"helm.sh/hook-weight": "-10"
# "helm.sh/hook-delete-policy": hook-succeeded
labels:
app: cache-server-cert-manager
application-crd-id: kubeflow-pipelines
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
apiVersion: apps/v1
kind: Deployment
metadata:
annotations:
"helm.sh/hook": pre-install
"helm.sh/hook-weight": "-8"
# "helm.sh/hook-delete-policy": hook-succeeded
labels:
app: cache-server
app.kubernetes.io/component: ml-pipeline
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.create_secret }}
apiVersion: v1
kind: Secret
metadata:
Expand All @@ -8,3 +9,4 @@ metadata:
stringData:
accesskey: ''
secretkey: ''
{{- end }}
3 changes: 2 additions & 1 deletion charts/apps/kubeflow-pipelines/rds-s3/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ s3:
bucketName:
minioServiceHost: s3.amazonaws.com
minioServiceRegion:
roleArn:
roleArn:
create_secret: false
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: autoscaling/v2beta2
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
labels:
Expand All @@ -20,4 +20,4 @@ spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: webhook
name: webhook
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.create_config }}
apiVersion: v1
data:
AUTHSERVICE_URL_PREFIX: /authservice/
Expand All @@ -14,3 +15,4 @@ kind: ConfigMap
metadata:
name: oidc-authservice-parameters
namespace: istio-system
{{- end }}

This file was deleted.

3 changes: 1 addition & 2 deletions charts/common/oidc-authservice/values.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
null
...
create_config: false
23 changes: 23 additions & 0 deletions charts/hyperfine/user/.helmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*.orig
*~
# Various IDEs
.project
.idea/
*.tmproj
.vscode/
Loading

0 comments on commit d4e0a1d

Please sign in to comment.