add include and exclude to test and run service labelValues endpoint #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willr3
force-pushed
the
labelValueFilter
branch
from
a1eb9df
to
fa23fb7
Compare
stalep
reviewed
Mar 25, 2024
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/RunServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-api/src/main/java/io/hyperfoil/tools/horreum/api/services/TestService.java
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/RunServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/RunServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/RunServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/TestServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/TestServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/TestServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/TestServiceTest.java
Outdated
Show resolved
Hide resolved
horreum-backend/src/test/java/io/hyperfoil/tools/horreum/svc/TestServiceTest.java
Outdated
Show resolved
Hide resolved
willr3
force-pushed
the
labelValueFilter
branch
from
fa23fb7
to
ec3b363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labelValuescan contain a large number of entries or a large amount of data depending on how a team uses labels. Including all labels for every request can create large json responses and impact the performance of Horreum and the perceived peformance of services that consume the endpoint.This adds the
includeandexcludequery parameters to thelabelValuesendpoint for both runs and tests so that users have more control over what data they fetch from Horreum.Closes #1530