Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct result type #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

euri10
Copy link

@euri10 euri10 commented Feb 3, 2021

Currently the type of a jsonrpc result is a JsonPrimitive while it is a JsonDict in fact,
this PR corrects that, it is built on top of the previous one I sent but I can seperate it if deemed necessary, currently using my forked branch hence why :)

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #5 (af4cd42) into master (66b1dbc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          205       205           
=========================================
  Hits           205       205           
Impacted Files Coverage Δ
sansio_jsonrpc/main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b1dbc...af4cd42. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant