#3404: Added Configuration settings for comment visibility. #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
requested changes
May 12, 2023
hypha/apply/activity/models.py
Outdated
| @@ -136,11 +136,11 @@ def __str__(self): | |||
| @classmethod | |||
| def visibility_for(cls, user): | |||
| if user.is_apply_staff: | |||
| return [APPLICANT, TEAM, REVIEWER, PARTNER, ALL] | |||
| return getattr(settings, "COMMENT_VISIBILITY_ADMIN", []) | |||
There was a problem hiding this comment.
Can we not use return settings.COMMENT_VISIBILITY_ADMIN etc. here? It will always be set since it is in base.py.
There was a problem hiding this comment.
Also prefer COMMENT_VISIBILITY_STAFF instead of COMMENT_VISIBILITY_ADMIN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a configuration setting that allows for the customization of the visibility of comments made by admins, reviewers, and partners. This feature provides flexibility and allows for easy modification without the need to manually adjust settings in the models.
Recently, ARDC required the removal of partner from comment visibility, which was easily accomplished by updating the new setting.
Settings to consider:
COMMENT_VISIBILITY_ADMINCOMMENT_VISIBILITY_REVIEWERCOMMENT_VISIBILITY_PARTNERCloses #3404