-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoice status updating improvements #4083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wes-otf instead of rendering each of the one by one during initial page load, either you can load the invoices from server as it was getting loaded before and only when the status changed update the row data.
Or if you want to save up some queries and load the invoices section async, then I would suggest load all the rows at once, and then when a particualar invoices is update either re-render all the invoices row or just trigger fetch and update of a single row.
91d0219
to
5afec10
Compare
@wes-otf You can update invoice status on the invoice detail page as well. I think that function also need to be updated to use htmx, getting some errors when using it now. |
@wes-otf When you are on the invoice detail template can you make it so the show/hide for activities only show when there are more than 1 activity? |
2c043f8
to
ebb7e0d
Compare
thanks for the catch @frjo, totally missed that. I think all should work now - didn't update the batch prompt because that seems a little out of scope but that'll probably be in line next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
Some merge conflicts in |
94b462f
to
6c62a80
Compare
6c62a80
to
57445d2
Compare
57445d2
to
effb2c1
Compare
effb2c1
to
171615a
Compare
Fixes #3208. Implemented an improvement for the picklist where radio buttons will be shown when there are less than 4 options. Otherwise the prompt will be like it was before.
This PR also implements HTMX for the invoice updating prompt, allowing invoices in table to be updated w/o refreshing the pages
Test Steps