Fix 'Reminder Created' duplicate message, restrict duplicate toast messages #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the duplicate message dispatch be removed, instead of handling it after it's sent. The duplicate seems to be because the django messages framework also creates a entry, and it's that's is happening only one should send the message, either the view function or django messages framework. |
frjo
added
Type: Bug
frjo
added
Status: Needs testing
frjo
approved these changes
Sep 16, 2024
|
@frjo I think this one is good merge now? |
frjo
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
theskumar
added a commit
that referenced
this pull request
Oct 10, 2024
…pdate-test-packages * origin/main: Fix js error when no proposal field on determination form. (#4147) Fix 'Reminder Created' duplicate message, restrict duplicate toast messages (#4126) Rename past submission to other submissions (#4143) Add content from Hypha site to docs front page. (#4139) Lock griffe version, breaking change in v1.x. (#4138) Update micromatch. (#4137) Added command to delete drafts that haven't been modified in specified days (#4133) Updated the sandbox db. (#4135) Updated the sandbox db. (#4132) Update PAF to Project Form in user facing strings (#4104) Add invoice date and paid date to invoice and invoices lists and tables (#4019) Added links & icons to wagtail form view `Used By` columns (#4106) New submission table view (#4080) Update makefile, auto-help and better serve (#4109)
sandeepsajan0
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4082
Test Steps