Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fancybox modal for Contracting #4174

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove fancybox modal for Contracting #4174

wants to merge 6 commits into from
+559 −381

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Oct 21, 2024 •
edited
Loading

Fixes #4124

  • Use htmx/alpine for Upload contract modal
  • Use htmx/alpine for Upload and remove contracting documents modal
  • Use htmx/alpine for submit contracting documents modal
  • Use htmx/alpine for approve contract modal

Test Steps

  • …

@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review October 22, 2024 10:33
@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/remove-fancybox-contracting branch from d2180ca to ecada27 Compare October 27, 2024 04:48
@frjo frjo mentioned this pull request Oct 31, 2024
Merged
8 tasks
@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/remove-fancybox-contracting branch from 206e3b3 to 03919ae Compare November 3, 2024 11:01
@sandeepsajan0 sandeepsajan0 changed the base branch from enhancement/gh-4124-remove-fancybox to main November 3, 2024 11:01
@sandeepsajan0 sandeepsajan0 requested review from frjo, wes-otf and theskumar and removed request for frjo and wes-otf November 3, 2024 11:08
frjo
frjo approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter labels Nov 4, 2024
@frjo frjo force-pushed the enhancement/remove-fancybox-contracting branch from 03919ae to 0d9941c Compare November 4, 2024 14:11
@frjo
Copy link
Contributor

frjo commented Nov 4, 2024 •
edited
Loading

A merge conflict in contracting_documents.html with other PR on test makes me hold off on this for a bit.

@frjo
Copy link
Contributor

frjo commented Nov 13, 2024

@sandeepsajan0 I have merged in #4136 now so this PR needs a rebase before we can put it on test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo frjo approved these changes

@theskumar theskumar Awaiting requested review from theskumar

@wes-otf wes-otf Awaiting requested review from wes-otf

Assignees
No one assigned
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Minor Minor change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert remaining fancybox uses to htmx/alpine
2 participants
@sandeepsajan0 @frjo