Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sb) #493

Merged
merged 24 commits into from
Mar 5, 2024
Merged

fix(sb) #493

merged 24 commits into from
Mar 5, 2024

Conversation

Kathund
Copy link
Member

@Kathund Kathund commented Feb 22, 2024

Please describe changes
Fix SB bugs that happened when switched to v2 endpoints

  • I've added new features. (methods or parameters)
  • I've added jsdoc and typings.
  • I've fixed bug. (optional you can mention a issue if there is one)
  • I've corrected the spelling in README, documentation, etc.
  • I've tested my code. (npm run test)
  • I've check for issues. (npm run eslint)
  • I've fixed my formatting. (npm run prettier)

src/structures/SkyBlock/SkyblockInventoryItem.js Outdated Show resolved Hide resolved
src/structures/SkyBlock/SkyblockInventoryItem.js Outdated Show resolved Hide resolved
src/structures/SkyBlock/SkyblockMember.js Show resolved Hide resolved
src/structures/SkyBlock/SkyblockMember.js Outdated Show resolved Hide resolved
src/structures/SkyBlock/SkyblockMember.js Show resolved Hide resolved
@Kathund
Copy link
Member Author

Kathund commented Feb 27, 2024

lgtm, once getMuseum gets implemented, add it to the networth calculation

Should be a thing now

@Kathund Kathund requested a review from DuckySoLucky February 27, 2024 05:36
@Kathund Kathund enabled auto-merge (squash) March 5, 2024 02:46
@Kathund Kathund merged commit 4cc7cfd into master Mar 5, 2024
18 checks passed
@Kathund Kathund deleted the sb branch March 5, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants