[WIP] fix from_type under Python 3.7 #1402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1264, closes #1148.
from_type
puppy again; given that thetyping
module is still provisional I expect to do this again for 3.8 😭. This means addingTypeVar
support because bare generics now have explicit typevars as their contents at runtime (ugh), and adding yet another set of compatibility shims and conditional logic. It's not pretty but it does all work.dataclasses
already work via the existing annotation-based machinery - it's a miracle of unusually restrained design, but there you are.