Make assigning attributes of the settings class an error #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
assign-settings
branch
from
7423109
to
07f6ebb
Compare
DRMacIver
reviewed
Sep 14, 2018
hypothesis-python/RELEASE.rst
Outdated
| RELEASE_TYPE: minor | ||
|
|
||
| To adjust the current settings profile, you can assign to the current settings | ||
| *instance* ``hypothesis.settings.default``. This release makes it an error to |
There was a problem hiding this comment.
Do we actually still allow this? I thought we didn't.
There was a problem hiding this comment.
Whoops, no, we don't! I will update have updated the notes and error messages.
Zac-HD
force-pushed
the
assign-settings
branch
2 times, most recently
from
2e5af06
to
71cb648
Compare
You probably meant to assign them on an (or the default) *instance*.
Zac-HD
force-pushed
the
assign-settings
branch
from
71cb648
to
c3bec7f
Compare
auvipy
approved these changes
Sep 17, 2018
DRMacIver
approved these changes
Sep 24, 2018
marsam
added a commit
to marsam/vdirsyncer
that referenced
this pull request
Nov 30, 2018
Since Hypothesis 3.72.0, assigning settings attributes throws an error. See: HypothesisWorks/hypothesis#1572
spk
pushed a commit
to spk/vdirsyncer
that referenced
this pull request
Jun 10, 2019
Since Hypothesis 3.72.0, assigning settings attributes throws an error. See: HypothesisWorks/hypothesis#1572
spk
pushed a commit
to spk/vdirsyncer
that referenced
this pull request
Jun 10, 2019
Since Hypothesis 3.72.0, assigning settings attributes throws an error. See: HypothesisWorks/hypothesis#1572
flopraden
pushed a commit
to flopraden/vdirsyncer
that referenced
this pull request
Nov 13, 2019
Since Hypothesis 3.72.0, assigning settings attributes throws an error. See: HypothesisWorks/hypothesis#1572 (cherry picked from commit 22ad88a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've now seen a couple of places have to debug timeout or healthcheck (etc) problems where their settings were having no effect... because they were assigning them on the class
hypothesis.settings, and thus missing the explicit error from trying to mutate a settings instance. Since errors should never pass silently, trying this now raises anAttributeErrortoo.