Increase variation in Unicode character generation #1621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
character-generation
branch
7 times, most recently
from
b678f58
to
f4f4635
Compare
Zalathar
reviewed
Oct 6, 2018
Zac-HD
force-pushed
the
character-generation
branch
from
f4f4635
to
fb7b08b
Compare
DRMacIver
reviewed
Oct 9, 2018
Zac-HD
force-pushed
the
character-generation
branch
2 times, most recently
from
dad21c7
to
33c6223
Compare
Zac-HD
changed the title
|
OK! I've tidied this up and ensured that the increased variety in generation does not change shrinking. Ready for another review 😄 |
Zac-HD
force-pushed
the
character-generation
branch
from
33c6223
to
0ed071f
Compare
DRMacIver
reviewed
Oct 24, 2018
Zac-HD
force-pushed
the
character-generation
branch
2 times, most recently
from
b03bfaa
to
79f85fa
Compare
DRMacIver
reviewed
Oct 25, 2018
Zac-HD
force-pushed
the
character-generation
branch
4 times, most recently
from
38284e6
to
aa894b5
Compare
|
Hmm. After digging into this, it looks like it's not fully broken - instead, there are some tests that don't reliable shrink to a fixpoint within the 500 shrink limit. @DRMacIver, any idea what I should do about that? |
Zac-HD
force-pushed
the
character-generation
branch
from
aa894b5
to
b0b97b9
Compare
Zac-HD
force-pushed
the
character-generation
branch
from
b0b97b9
to
396e56c
Compare
When passed an alphabet of characters (not a strategy), we can do much better for shrinking than simply sampling from it - delegating to characters() if possible or sorting before sampling otherwise.
Zac-HD
force-pushed
the
character-generation
branch
from
396e56c
to
f1f951d
Compare
|
I'm going to close this issue for now, as while the approach is promising there is also something of a clash between the generation and shrinking steps and I simply don't want to work on the frustration last ~5% of the problem at the moment. |
This was referenced Dec 18, 2018
|
Rebased and (somewhat) updated version: master...Zac-HD:weird-text - shrinking isn't quite right at the moment but everything else seems to be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch substantially increases the variety of examples from the
characters()strategy. Instead of generating directly from codepoint,characters()now selects a Unicode category and then a code point within that category. However the shrink target is unchanged, as the choice of category 'shrinks open' to allow codepoint-wise minimisation during shrinking.I've extracted the unrelated cleanups and refactoring as #1660 - it would be great if that can be reviewed and merged soon, so I can rebase on it.
Closes #1401 and closes #341.