Hook for managing any Random instance #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
any-prng
branch
2 times, most recently
from
ccaf274 to
6144fdb
Compare
auvipy
approved these changes
Jan 8, 2019
Zac-HD
force-pushed
the
any-prng
branch
4 times, most recently
from
aff3a20 to
b794074
Compare
|
Ping @HypothesisWorks/hypothesis-python-contributors for review - I finally got all the tests passing at once! If this API looks OK, I'd love to get it merged soon for the benefit of pytest-trio 😄 |
DRMacIver
reviewed
Jan 22, 2019
There was a problem hiding this comment.
The implementation looks fine, but I think the API needs maybe a bit more thought.
- I'm not wild about
random_module.registeras the thing you need to call. It's both a strange API and also fairly non-obvious in that the things you pass to it don't logically have much to do with therandom_modulestrategy. I think a top-level function likeregister_randomor something like that would make more sense. - The fact that the function checks that the value of type
Randomis weird given that we are putting things in it that are notRandominstances ourselves - this seems like a general use case. I would rather we use duck typing and document the interface we require.
|
@DRMacIver - done 😄 |
DRMacIver
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalises our management of the global random and numpy.random states to work for any registered Random instance. That's useful for simulation and scheduling frameworks that maintain their own random state, such as Trio.
Closes #1709, related to python-trio/trio#239 and python-trio/pytest-trio#73