Obtain the last block's length without having to create it #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalathar
force-pushed
the
last-block-length
branch
from
fab7caf
to
42ecad5
Compare
Zac-HD
approved these changes
Mar 18, 2019
|
Thanks @Zalathar! I really appreciate your attention to the internal details - it's often invisible to users, but no less important for that 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the one call site that was causing
Blockallocation during generation, after #1830.(It was originally a part of #1862, but I pulled it out here because it's a perfectly fine incremental improvement on its own.)
In theory this could enable some simplifications of the lazy block management code, but in practice I haven't actually investigated any of those yet.