Improved get_type_hints() for classes with forward references
#2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
dataclass-type-hints
branch
8 times, most recently
from
8bf78e3
to
dad8411
Compare
rsokl
requested changes
Apr 23, 2020
| # Special handling for typing.NamedTuple | ||
| return thing._field_types # type: ignore | ||
| thing = thing.__init__ # type: ignore | ||
| """Like the typing version, but tries harder and never errors. |
There was a problem hiding this comment.
Now this is a docstring. Can we have these sorts of docs from all of hypothesis.internal please?
There was a problem hiding this comment.
😂 Be the change you want to see in the world!
Zac-HD
force-pushed
the
dataclass-type-hints
branch
from
dad8411
to
4bb67e4
Compare
rsokl
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by some work on Zac-HD/hypothesmith#2. Happily, it also fixes #1004 - since I last prodded at that issue the typing ecosystem has improved and we're mostly 3.6+ and so a fairly simple approach now works 🎉