Tighten up some internal type annotations #3395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Folded into #3396. |
rsokl
reviewed
Jul 4, 2022
Comment on lines
+18
to
+21
| try: | ||
| from typing import TypeAlias | ||
| except ImportError: | ||
| TypeAlias = object # type: ignore |
There was a problem hiding this comment.
To avoid the pyright fail case I think you want to fall back on TypeAlias being Any:
try:
from typing import TypeAlias
except ImportError:
try:
from typing_extensions import TypeAlias
except ImportError:
from typing import Any as TypeAliasThere was a problem hiding this comment.
The fix I went with was "instead of moving the Real alias, just use SupportsFloat like a sensible person"; see the other PR for that 😁
There was a problem hiding this comment.
The fix I went with was "instead of moving the Real alias, just use SupportsFloat like a sensible person"; see the other PR for that 😁
🤩
I am sooooo stealing this for some of my projects!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily enabling Mypy's strict-equality check, plus a few other clarifying annotations while I was going through.