Include namespace classes in pretty printing #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just turn off the 3.14 builds on PRs until they're less broken? Having to explicitly skip every test that uses attrs is tedious. |
Zac-HD
approved these changes
Oct 19, 2024
DRMacIver
force-pushed
the
DRMacIver/qualname-in-pretty
branch
from
afaa36e to
479ca98
Compare
Zac-HD
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone pointed out to me that the changes from #4133 now meant some nested types they had were no longer pretty printing with their namespace (despite this being in their repr). This PR fixes that. I also noticed that we had the same problem with enum types declared nested, so I fixed that too.