This repository has been archived by the owner on Jun 15, 2020. It is now read-only.
Remove pub/#[no_mangle] decorators on lang items #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was poking around this wasm project to double check that the wasm module is appropriately sized, but to my surprise there were some stray symbols exported from the wasm module! Specifically the wasm module currently exports `rust_begin_unwind` and `rust_oom` symbols, but neither of these should be exported. The `#[panic_implementation]` and `#[alloc_error_handler]` attributes should render the `pub` and `#[no_mangle]` annotations unnecessary, however, and the compiler manages the symbol business internally with the wrapper it generates.
|
There's still some stray symbols, but they should be fixed by rust-lang/rust#52993! |
|
Sorry, I did not see the notifications about your PR… Post-holidays effect probably. Anyway, thank you very much, that's true |
Hywan
approved these changes
Aug 21, 2018
|
Hmm, Github erases the author when I modify the commit message, 7669260. I'm gonna fix that. |
|
Author fixed, 69c0609. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was poking around this wasm project to double check that the wasm module is
appropriately sized, but to my surprise there were some stray symbols exported
from the wasm module! Specifically the wasm module currently exports
rust_begin_unwindandrust_oomsymbols, but neither of these should beexported.
The
#[panic_implementation]and#[alloc_error_handler]attributes shouldrender the
puband#[no_mangle]annotations unnecessary, however, and thecompiler manages the symbol business internally with the wrapper it generates.