-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed the single submenus as per issue:OGC-17 #1354
base: develop
Are you sure you want to change the base?
Conversation
All the nav links are working as expectedScreencast.from.21-12-24.05.15.14.PM.IST.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @vsvishalsharma , did you run this command cd frontend and then npm run format ??
72c04ff
to
f90839b
Compare
@Bahati308 thanks for mentioning it ! |
f90839b
to
c71b1fb
Compare
@caseyi ,@mozzy11 i need your feedback on Issue:Current test flows expect dropdown navigation for Pathology/Immunochemistry menus, but we simplified UX for single-submenu cases to use direct links. This breaks existing tests. impact:
Options:Update test flows to match new UX I can implement either solution and am willing to consider any other approach based on your feedback! |
@vsvishalsharma Option 1 is definitely a way to go just modify dashboard.cy.js file and test it locally and make sure the test is passing locally on a fresh instance. |
welcome. Did you run it, you need to pass the checks locally. In case of any challenge, reach out |
1184a2f
to
0242577
Compare
0242577
to
fbdc5ca
Compare
@adityadeshlahre if possible can you run the ci on this |
seems like all cypress tests are passing at least in headless mode 🙂 |
Pull Request Requirements
Summary
This PR resolves issue OGC-17 by improving the navigation menu functionality. It ensures that if a menu has only one submenu, the submenu is replaced with a direct link, using the parent menu's name as the navigation label. This enhancement simplifies user interaction by reducing unnecessary nesting in the navigation structure.
Screenshots
Before: Submenu were displayed even when there was only one submenu.
After: Direct link is shown for menus with a single submenu.
Related Issue
OGC-17
#1359