Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip output from notebooks, include test data for executing them, add explanation in README.md #27

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

juanep97
Copy link
Collaborator

@juanep97 juanep97 commented Dec 5, 2021

This PR clears notebooks output, includes test data for executing them and adds a warning in README.md so everyone knows how to clean cell ouputs before commiting.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanep97 juanep97 linked an issue Dec 5, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #27 (ff7e8de) into main (2a75bf1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files           9        9           
  Lines         786      786           
=======================================
  Hits          726      726           
  Misses         60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a75bf1...ff7e8de. Read the comment docs.

@juanep97 juanep97 requested a review from Bultako December 5, 2021 22:38
@juanep97 juanep97 added cleaning documentation Improvements or additions to documentation labels Dec 5, 2021
@juanep97 juanep97 self-assigned this Dec 5, 2021
@juanep97
Copy link
Collaborator Author

juanep97 commented Dec 6, 2021

Tested branch, it has no conflict, everything is working. I merge.

@juanep97 juanep97 merged commit ce1e5fb into main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove notebooks output
1 participant