Auction orchestration #147
Conversation
|
|
||
| ### Auction Flow | ||
| A named configuration that defines: | ||
| - Which providers participate |
There was a problem hiding this comment.
Confirming "providers" means wrappers?
| - Which providers participate | ||
| - Execution strategy (parallel, waterfall, etc.) | ||
| - Timeout settings | ||
| - Optional mediator |
There was a problem hiding this comment.
mediator = final ad-server?
| strategy = "parallel_mediation" | ||
| bidders = ["prebid", "aps"] | ||
| mediator = "gam" | ||
| timeout_ms = 2000 |
There was a problem hiding this comment.
timeout meaning the time for PBS, APS etc to come back to TS right? This does not include any GAM RT's or think time?
|
|
||
| **Flow:** | ||
| 1. Prebid and APS run in parallel | ||
| 2. Both return their bids simultaneously |
There was a problem hiding this comment.
Better way to say is that "Both return their bids within a time window" as they'll never be simultaneous
|
|
||
| **Flow:** | ||
| 1. All bidders run in parallel | ||
| 2. Highest bid wins |
There was a problem hiding this comment.
This may be addressed elsewhere, but AFAIK APS doesn't return a clear text creative bid, so we'll need to understand what the decryption of the TAM value looks like
crates/common/src/auction/README.md
Outdated
|
|
||
| **Flow:** | ||
| 1. Try Prebid first | ||
| 2. If Prebid returns no bids, try APS |
There was a problem hiding this comment.
Let's discuss this on a call as it's not really a realistic scenario where PBS comes back with nothing and I don't know any pubs interested in waterfalls these days. We also need to make sure we are considering bid floors set by publishers here. Maybe I'm missing context?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ChristianPavilonis
force-pushed
the
feature/auction-integrations
branch
from
92c19a7 to
39cb7dc
Compare
ChristianPavilonis
force-pushed
the
feature/auction-integrations
branch
from
39cb7dc to
c82ffd3
Compare
aram356
left a comment
aram356
left a comment
There was a problem hiding this comment.
👍 Good start
- Please address tests and formatting
- I would like to re-review
| @@ -0,0 +1,188 @@ | |||
| # APS Integration Quick Start | |||
There was a problem hiding this comment.
⛏️ Should be lower case file and be inside guide
| @@ -0,0 +1,484 @@ | |||
| //! Auction orchestration module for managing multi-provider bidding. | |||
There was a problem hiding this comment.
⛏️ Preferable not to have this much logic in mod.rs
| .sizes | ||
| .iter() | ||
| .map(|size| AdFormat { | ||
| width: size[0], |
There was a problem hiding this comment.
🔧 Index reference without check
| @@ -0,0 +1,314 @@ | |||
| # Amazon Publisher Services (APS) Integration | |||
There was a problem hiding this comment.
🔧 Move this to guide and combine the guides with
|
|
||
| let decoded = match STANDARD.decode(encoded) { | ||
| Ok(bytes) => bytes, | ||
| Err(_) => return 2.50, |
There was a problem hiding this comment.
🔧 Add this as setting for default
🤔 We should logs errors
| timeout_ms = 800 | ||
|
|
||
| # Mock GAM Configuration (for testing) | ||
| [integrations.gam_mock] |
There was a problem hiding this comment.
🔧 Why we need this because mocking is separated into different service
| /// | ||
| /// Initialized once on first access with the provided settings. | ||
| /// All providers are registered during initialization. | ||
| static GLOBAL_ORCHESTRATOR: OnceLock<AuctionOrchestrator> = OnceLock::new(); |
There was a problem hiding this comment.
⛏️ Would be harder to test with these global singletons
| } | ||
|
|
||
| /// Select the best bid for each slot from all responses. | ||
| fn select_winning_bids(&self, responses: &[AuctionResponse]) -> HashMap<String, Bid> { |
There was a problem hiding this comment.
🔧 We are not checking floor price
| })?; | ||
|
|
||
| // Generate proxy URL for the creative | ||
| let url = format!( |
There was a problem hiding this comment.
🔧 Add token to decode on request to prevent fraud.
Closes #139