Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose file to e2e #4

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

cYKatherine
Copy link
Contributor

No description provided.

@gmsdelmundo
Copy link
Collaborator

gmsdelmundo commented Dec 13, 2023

I think we can add a profile in publicoperator service called public_operator: (https://docs.docker.com/compose/profiles/)

Then, when calling docker compose up:

  • If we're building a public operator, the public_operator profile can be set and publicoperator service will be spun up
  • For private operator builds, don't pass a profile as an argument, and the publicoperator service will not be started

But this can be done later on when working on private operator pipelines

@cYKatherine cYKatherine force-pushed the kcc-UID2-2338-build-test-pipeline-for-operator branch from f3bc1b6 to 726dafe Compare December 13, 2023 23:46
@cYKatherine cYKatherine force-pushed the kcc-UID2-2338-build-test-pipeline-for-operator branch from 726dafe to b25dd94 Compare December 13, 2023 23:48
@cYKatherine
Copy link
Contributor Author

cYKatherine commented Dec 13, 2023

I think we can add a profile in publicoperator service called public_operator: (https://docs.docker.com/compose/profiles/)

Then, when calling docker compose up:

  • If we're building a public operator, the public_operator profile can be set and publicoperator service will be spun up
  • For private operator builds, don't pass a profile as an argument, and the publicoperator service will not be started

But this can be done later on when working on private operator pipelines

My understanding from the setup for uid2-dev-workspace is that the only difference between spinning up a public operator and a private one is that the latter one is using local-e2e-docker-private-config.json while the public one is using local-e2e-docker-public-config.json.

In this action, I passed the operator type as an input, and it will also be used here to determine whether it's a public operator or a private one. The default value is set to be public so we will use it as a public operator by default. wdyt?

@gmsdelmundo


core:
container_name: core
image: ghcr.io/iabtechlab/uid2-core:<CORE_VERSION>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to set this to uid2-core:latest so that it can still be run locally

Then the regex in the pipeline script should be updated to capture uid2-core:latest rather than <CORE_VERSION>

Same applies for other versions in this file

@cYKatherine cYKatherine merged commit b441eed into main Dec 15, 2023
1 check passed
@cYKatherine cYKatherine deleted the kcc-UID2-2338-build-test-pipeline-for-operator branch December 18, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants