Removing assertions from code and replacing with relevant exceptions #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asloobq
commented
Oct 17, 2024
| return this.processPartitions(iuc); | ||
| } else { | ||
| // array size cannot be a negative value | ||
| assert numPartitions == 1; |
Contributor
Author
There was a problem hiding this comment.
this condition is always true
asloobq
commented
Oct 17, 2024
| } else if (numPartitions > 1) { | ||
| // should not load more than 1 partition at a time, unless during service bootstrap | ||
| assert this.iteration == 0; | ||
| if (this.iteration != 0) { |
sunnywu
reviewed
Oct 18, 2024
pom.xml
Outdated
| <groupId>com.uid2</groupId> | ||
| <artifactId>uid2-operator</artifactId> | ||
| <version>5.40.86</version> | ||
| <version>5.40.87-alpha-110-SNAPSHOT</version> |
Contributor
There was a problem hiding this comment.
this should be removed from the final merge?
Comment on lines
37
to
40
| assert item1 != null; | ||
| assert item2 != null; | ||
| assert item3 != null; | ||
| if (item1 == null || item2 == null || item3 == null) { | ||
| throw new NullPointerException(); | ||
| } |
Contributor
There was a problem hiding this comment.
The line number in the stack trace won't tell us which of the items is null. Suggest instead
this.item1 = Objects.requireNonNull(item1);
this.item2 = Objects.requireNonNull(item2);
this.item3 = Objects.requireNonNull(item3);
Same for the other Tuple.
| } | ||
|
|
||
| assert messageItem != null; | ||
| if (messageItem == null) { |
Contributor
There was a problem hiding this comment.
Can readValue return null?
Contributor
Author
There was a problem hiding this comment.
Looks like it won't return a null value. If the input string is null it throws an IllegalArgumentException and Json*Exception for bad json string. I'll remove this check. Thanks
Comment on lines
156
to
161
| try { | ||
| V2RequestUtil.handleRefreshTokenInResponseBody(jsonBody, keyManager, IdentityScope.UID2); | ||
| fail("IllegalArgumentException not thrown"); | ||
| } catch (IllegalArgumentException e) { | ||
| assertEquals("Generated refresh token's length=168 is not equal to=388", e.getMessage()); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggestion:
Suggested change
| try { | |
| V2RequestUtil.handleRefreshTokenInResponseBody(jsonBody, keyManager, IdentityScope.UID2); | |
| fail("IllegalArgumentException not thrown"); | |
| } catch (IllegalArgumentException e) { | |
| assertEquals("Generated refresh token's length=168 is not equal to=388", e.getMessage()); | |
| } | |
| IllegalArgumentException e = assertThrowsExactly( | |
| IllegalArgumentException.class, | |
| () -> V2RequestUtil.handleRefreshTokenInResponseBody(jsonBody, keyManager, IdentityScope.UID2)); | |
| assertEquals("Generated refresh token's length=168 is not equal to=388", e.getMessage()); |
sunnywu
reviewed
Oct 22, 2024
| return null; | ||
| } | ||
|
|
||
| private boolean checkForInvalidTokenInput(InputUtil.InputVal input, RoutingContext rc) { |
Contributor
There was a problem hiding this comment.
good that you renamed checkForInvalidTokenInput as after reading the original codes and what bool it returns, this method name is highly deceptive!
sunnywu
approved these changes
Oct 22, 2024
mcollins-ttd
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
TODO