Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbounded path label #132

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vishalegbert-ttd
Copy link
Contributor

No description provided.

@aulme
Copy link
Contributor

aulme commented Nov 22, 2024

Thanks for fixing, happy to merge as is.

I think it would still be better if we scraped routes from the router as this approach won't work if we use nested routers and someone may forget adding their new paths to the enum resulting in no obvious failure but no metrics. Don't know if you've tried looking at this, eg the way it's described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants