Copy changes for root-level domains and mobile app IDs #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-yau-ttd
commented
Aug 28, 2024
| @@ -163,7 +163,7 @@ describe('CstgAddDialog', () => { | |||
| onOpenChange={() => {}} | |||
| existingCstgValues={[]} | |||
| cstgValueType={CstgValueType.MobileAppId} | |||
| addInstructions='Please register the Android App ID, iOS/tvOS Bundle ID and iOS App Store ID.' | |||
There was a problem hiding this comment.
This string is no longer accurate and isn't even needed. Figured I would remove all of them in this file
ashleysmithTTD
approved these changes
Aug 28, 2024
alex-yau-ttd
deleted the
ajy-UID2-3848-Copy-changes-for-root-level-domains-and-mobile-app-IDs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-exhaustive demo
chrome_zQguZdCl6K.mp4
chrome_fV4c40TojB.mp4