Refactor some user invite code #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why? I'm about to change the functionality to allow user invitations to still work when the user already belongs to another participant. I'm doing this refactoring to make it easier for me to add that functionality as well as make it easier to be reviewed. ## What? - Rename a function to avoid confusion with an upcoming function to send an invite to an existing user - Split out the handler for inviting a new participant/user to participantsUsers - Break down the handler for creating a new participant
alex-yau-ttd
commented
Sep 2, 2024
| @@ -210,7 +202,7 @@ export function createParticipantsRouter() { | |||
| } | |||
| ); | |||
|
|
|||
| participantsRouter.put('/', createParticipant); | |||
| participantsRouter.put('/', handleCreateParticipant); | |||
There was a problem hiding this comment.
Renamed because I split the handler into two functions, one of which is called createParticipant
alex-yau-ttd
commented
Sep 2, 2024
| } | ||
| } | ||
| ); | ||
| participantsRouter.post('/:participantId/invite', handleInviteUserToParticipant); |
There was a problem hiding this comment.
extracted this out - functionality is the same (will be changed in a subsequent PR)
We only have the one keycloak user role, so extracted into it's own method and constant, so we have less magic strings.
My alt+shift+O command removed them. Saving the file added them back
ashleysmithTTD
approved these changes
Sep 4, 2024
alex-yau-ttd
deleted the
ajy-UID2-3878-Refactor-some-user-invite-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
#516 will be changing the functionality to allow user invitations to still work when the user already belongs to another participant. I'm doing this refactoring to make it easier for me to add that functionality as well as make it easier to be reviewed.
What?
participantsUsers.ts