Align property names in AddParticipantForm
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match property names in `AddParticipantForm` to the input names in `AddParticipantDialog`
| @@ -185,6 +182,9 @@ export type AddParticipantForm = { | |||
| siteName?: string; | |||
| jobFunction: string; | |||
| crmAgreementNumber: string; | |||
| firstName: string; | |||
| lastName: string; | |||
| email: string; | |||
There was a problem hiding this comment.
Nit: maybe keep them at the top to preserve the order as before since it doesn't look like its in alphabetical order
There was a problem hiding this comment.
I moved them to the bottom to align with UpdateParticipantForm (and the UI itself). I'm not too concerned about preserving order, so I think I'll merge as-is. thanks!
ashleysmithTTD
approved these changes
Sep 3, 2024
alex-yau-ttd
deleted the
ajy-UID2-3878-Align-property-names-in-Add-Participant-Form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match property names in
AddParticipantFormto the input names inAddParticipantDialog. This mismatch prevented defaults to be set on the contact inputs, which was slowing down developer iteration.Manual testing
Still working like normal
chrome_TbqOM9q6bJ.mp4
With a default value set
chrome_1DIV00rS6U.mp4