Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iOS versioning for Cocoapods changes #111

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

dcaunt
Copy link
Contributor

@dcaunt dcaunt commented May 13, 2024

Updates required for changes in IABTechLab/uid2-ios-sdk#40

Version is now specified as a tuple in code, i.e. (1, 2, 0) so I have updated the parsing and substitution. Additionally, we need to bump the version contained in UID2.podspec.json, which is in the usual . separated form.

The final piece of this is an action to publish the CocoaPod. It requires a secret token, which I've registered in this repository's Settings. These tokens expire every 5 months or so. Should we make this step a separate workflow, to run after releasing?

- name: Publish CocoaPod to trunk
env:
    COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
run: |
    pod spec lint ${{ inputs.working_dir }}/UID2.podspec.json
    pod trunk push ${{ inputs.working_dir }}/UID2.podspec.json

@dcaunt dcaunt marked this pull request as ready for review May 13, 2024 19:10
@dcaunt dcaunt marked this pull request as draft May 13, 2024 19:11
@dcaunt dcaunt force-pushed the dave/ios-cocoapods-updates branch 2 times, most recently from 2c5727e to bc5a69a Compare May 14, 2024 13:09
@dcaunt dcaunt force-pushed the dave/ios-cocoapods-updates branch from bc5a69a to a33c236 Compare May 14, 2024 13:14
@dcaunt dcaunt marked this pull request as ready for review May 14, 2024 13:20
@dcaunt dcaunt merged commit a4adc4b into main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants