add contributor guidelines #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @danielhuppmann this looks like a great first cut. The JOSS reviewers include the following list: Do you think we cover everything there with existing docs + this PR? See the conversation here |
|
Yes, I had a look at the review discussion and the suggested examples for contributor guidelines (again).
1) Contribute to the software
Covered by paragraph 3
2) Report issues or problems with the software
Covered by paragraph 2
3) Seek support
Well, in the current status, I would say covered by paragraph 2. We may want to start a listserv or forum at some point - now?
… Am 17.12.2018 um 17:10 schrieb Matthew Gidden ***@***.***>:
Hey @danielhuppmann this looks like a great first cut. The JOSS reviewers include the following list:
Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support
Do you think we cover everything there with existing docs + this PR?
See the conversation here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Perfect, agreed. Just made one here: https://groups.google.com/forum/#!forum/pyam-iamc Mind updating this and then I can pull it in? |
|
added the reference to the Googlegroup in the contributor guidelines and on the documentation pages, updated the PR description to include the JOSS documentation review question (and all boxes now ticked off). |
|
Merging in so we can try to finish off Joss stuff today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple contributor guidelines document following the suggestion of reviewers at openjournals/joss-reviews#1095.