Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and housekeeping for 2024-W15 #48

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Apr 8, 2024

  • Use Pint's documented approach to cache registry instantiation.
  • Actually test against the earliest supported Pint version shown in pyproject.toml.
  • Add Python 3.12 to classifiers.
  • Replace black with ruff for code formatting.
  • Use latest ruff, mypy.
  • Bump GitHub Actions used in workflows, and add dependabot config to update these automatically in the future.

- Mypy to explicit v1.9.0.
- Replace black v23.7.0 with ruff v0.3.5 for both linting and
  formatting.
- Apply "ruff format ." to 1 file.
- Move ruff config to current preferred keys in pyproject.toml.
- actions/checkout v3 → v4.
- actions/setup-python v4 → v5.
- codecov/codecov-action v3 → v4.
- pre-commit/action v3.0.0 → v3.0.1.

Also, add dependabot config for GitHub Actions.
@khaeru khaeru added the enhancement New feature or request label Apr 8, 2024
@khaeru khaeru self-assigned this Apr 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (e22eab6) to head (d8e2abd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   75.28%   78.61%   +3.32%     
==========================================
  Files           5        5              
  Lines         174      173       -1     
==========================================
+ Hits          131      136       +5     
+ Misses         43       37       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khaeru
Copy link
Contributor Author

khaeru commented Apr 8, 2024

Actually test against the earliest supported Pint version shown in pyproject.toml.

Here we see:

AttributeError: module 'numpy' has no attribute 'alen'

This was removed in numpy 1.23.0, released 2022-06-23. Numpy 1.22.4 only provides wheels up to Python 3.10.

- Specify maximum version of numpy compatible with pint 0.11.
- Add fail-fast: false to allow other jobs to complete.
Adjust ReST for badges to render properly on GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants