Add extra functionality for cards #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-20
reviewed
Dec 11, 2024
| export const CardGallery: Story = { | ||
| render: () => | ||
| html`<div class="iati-card-gallery"> | ||
| ${Array(5).fill(Card.render?.call({}))} |
There was a problem hiding this comment.
Just curious, why is it Array(5)? Is that just a decision that the card gallery will contain 5 cards?
There was a problem hiding this comment.
Yeah, just a random number for example purposes :)
There was a problem hiding this comment.
Ah, I was reading way too much into it 😆
simon-20
approved these changes
Dec 11, 2024
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display: flexon.iati-card, in order to make positioning children elements easier e.g. being able to set things likealign-self: centeron children.iati-card-gallerycomponent for use cases with several cards together