Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Drop Python 3.4 support #300

Open
4 tasks done
hayfield opened this issue Mar 19, 2018 · 0 comments
Open
4 tasks done

Drop Python 3.4 support #300

hayfield opened this issue Mar 19, 2018 · 0 comments
Labels
awaiting-deployment The changes are complete, in `dev`, and waiting to be merged to `master` and released. code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. quick-and-easy An issue that on the face of it looks quick and/or easy. repo-management Changes relating to management of the repository.

Comments

@hayfield
Copy link
Contributor

hayfield commented Mar 19, 2018

pyIATI should drop support for Python 3.4.

3.4 support should be dropped because:

  • Current versions of operating systems come with 3.5 or 3.6 - these should support everything that 3.4 does
  • 3.7 will be out soon - supporting an ever-growing list of minor versions without dropping any is a bad thing
  • It's going EoL in 12 months time
  • It adds very little benefit, while increasing the time tests take to run, and occasionally causing problems
  • 3.4 lacks a number of features that could allow code to be simplified or made more robust (for example, around the testing of decorators).
  • The reason for supporting it initially was that early builds of pyIATI happened to work against it (but not 3.3, hence that was not supported)

  • Remove from Travis
  • Remove from setup.py
  • Remove from other places it's mentioned
  • Do a global search for 3.4 and remove / update code as appropriate to remove custom workarounds
@hayfield hayfield added code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. repo-management Changes relating to management of the repository. labels Mar 19, 2018
hayfield added a commit that referenced this issue Mar 22, 2018
The reasons for removal are details in #300
At this very point, the code still works with Python 3.4. Testing against this version, however, is being stopped. This means that at some unknown point in the future pyIATI will stop working with Python 3.4.
@hayfield hayfield added quick-and-easy An issue that on the face of it looks quick and/or easy. awaiting-deployment The changes are complete, in `dev`, and waiting to be merged to `master` and released. labels Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-deployment The changes are complete, in `dev`, and waiting to be merged to `master` and released. code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. quick-and-easy An issue that on the face of it looks quick and/or easy. repo-management Changes relating to management of the repository.
Projects
None yet
Development

No branches or pull requests

1 participant