Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Change constant meaning 'version independent' to not None #281

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

hayfield
Copy link
Contributor

@hayfield hayfield commented Feb 28, 2018

This allows == to be used to check whether a value is this or not, rather than requiring use of is. By doing this, it gives more scope to change the value in the future.

A constant has been added to contain this value, and should be used if this meaning is required.

For original explanation for change, see: #218 (comment)

This allows '==' to be used to check whether a value is this or not, rather than requiring use of 'is'.
By doing this, it gives more scope to change the value in the future.

A constant has been added to contain this value, and should be used if this meaning is required.

For original explanation for change, see:
    #218 (comment)
@hayfield hayfield added enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. complete A PR that is in a state that is ready for review. api Changes to the pyIATI API. labels Feb 28, 2018
@hayfield hayfield requested a review from a team February 28, 2018 11:07
@hayfield hayfield changed the base branch from improve-version-parameter to integrate-version-class February 28, 2018 11:12
@hayfield hayfield changed the base branch from integrate-version-class to improve-version-parameter February 28, 2018 11:12
@hayfield hayfield added the versions Relating to IATI Version Numbers. label Feb 28, 2018
@hayfield hayfield changed the base branch from improve-version-parameter to add-metadata March 7, 2018 12:30
@hayfield hayfield changed the base branch from add-metadata to improve-version-parameter March 7, 2018 12:30
Copy link
Contributor

@allthatilk allthatilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it would be great to refactor out that last case statement but with the complications of IATI versions, I'm not sure that's possible.

@hayfield hayfield merged commit c7c61e2 into improve-version-parameter Mar 9, 2018
@hayfield hayfield deleted the change-anyver-value branch March 9, 2018 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Changes to the pyIATI API. code-features Makes use of more capabilities in Python, or enables features such as iteration on a class. complete A PR that is in a state that is ready for review. enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). versions Relating to IATI Version Numbers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants