This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Improve speed of repaint on focus/unfocus #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly loses the cross-fade animation, but makes it feel snappier. We also have a minor bug where resizing while actions are visible can't track the grid height, but who activates actions on a tweet and *then* resizes the window? It all fixes itself after they toggle back to the tweet.
Part of the slow-down is because GTK invalidates and recalculates ALL of the widgets in the stack. But if we hide them then it doesn't need to do that. So when the transition ends, hide all widgets we're not showing. Currently seems to behave the same, but with faster focus switching.
If the actions can't know the right height as we resize then the only option is to stop showing the actions as we resize!
This is the harshest version of removing pages when we're not using them. We only keep extra pages in the stack until we're done with them. But the pages are still created and keep state, so they don't lose positions etc Also now pass the main window around so that we don't assume a base/parent when it might not be set. This won't work as-is with the libhandy redesign (because we need to keep all of the main tabs as children so we populate the switcher).
Apparently GTK is "smart" and doesn't do the transitions if it doesn't need to. This means that it spots our "add the impostor, change to it, and then swap back" shuffle. BUT if we always had the impostor then it (silently) swaps to the impostor and then happily transitions.
Although we call `show()`, GTK hasn't *actually* shown it yet, so it can't grab focus. But it tries. Which kicks us to the top of the feed! We now `connect_after` on size allocation (which happens when the widget is shown) to wait until we're done.
Size allocate only happens once if the action box is shown, hidden and shown again, so we need to hook on to other events. Always pushing focus to the TweetListEntry and then moving it to the RT button when necessary seems to work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK invalidates all GTK/CSS nodes when unfocusing refocusing. This is made worse by stacks, which are available (and invalidated) even when not the top item in the stack.
By dropping stacks and doing some other shuffles instead we seem to improve performance.