Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer_channel module doesn't need an operation field #269

Closed
sstone1 opened this issue Jun 3, 2020 · 0 comments
Closed

peer_channel module doesn't need an operation field #269

sstone1 opened this issue Jun 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@sstone1
Copy link
Contributor

sstone1 commented Jun 3, 2020

No description provided.

@sstone1 sstone1 added the enhancement New feature or request label Jun 3, 2020
sstone1 pushed a commit to sstone1/ansible-collection that referenced this issue Mar 25, 2021
…ckchain#269)

The `operation` parameter in the `peer_channel` module only has one option, `join`.

Remove the `operation` parameter from this module and make it like any other Ansible
module by having a `state` parameter instead. When `state` is set to `present`, ensure
that the peer is joined into the specified channel. When `state` is set to `absent`,
ensure that the peer is not joined into the specified channel.

Because peers can't currently leave a channel, attempting this will throw an error, but
this is on the Hyperledger Fabric roadmap and can be added at a later date.

These changes are compatible because any existing `operation` parameters will be ignored,
and the `state` parameter defaults to `present`, preserving existing behaviour.

Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant