Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create console/operator roles for OS Stack #610

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

mbwhite
Copy link
Collaborator

@mbwhite mbwhite commented Jul 18, 2022

Signed-off-by: Matthew B White whitemat@uk.ibm.com

@mbwhite mbwhite force-pushed the operator-console-install branch from f67a9c6 to 4d9ff49 Compare July 19, 2022 12:02
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
@mbwhite mbwhite force-pushed the operator-console-install branch from 4d9ff49 to 03802b7 Compare July 20, 2022 09:50
Copy link

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this, can't seem to delete. sorry

Dockerfile Outdated
@@ -4,7 +4,7 @@

# In the first stage, install the common dependencies, and then set up the standard user.
FROM registry.access.redhat.com/ubi8/ubi-minimal AS base
RUN microdnf install python38 shadow-utils git podman \
RUN microdnf install python38 shadow-utils git \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python39 not 38.

jkneubuh
jkneubuh previously approved these changes Jul 20, 2022
Copy link
Contributor

@jkneubuh jkneubuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant.

This is an incredible step forward. 👍

One "must fix" issue is to change Dockerfile:7 to install python39.

Some "nice to have" improvements, which can go in after 610 lands, or ... not (and tracked as Issues / feature enhancements in this repo):

  • Scrub all of the kind target and code paths. The supported targets can align with the offering attributes which are supported by the operator: [ k8s, openshift ]. Before the operator/console/ansible playbooks can run, the Nginx, DNS configuration, and kube storage class configuration should have been configured as upstream dependencies.

  • Use conda/miniconda environments to wrangle python and dependencies.

  • Migrate some of the static assets (resource templates, CRDs, etc.) to reference "release outputs" from the operator project via URL. (The requirement / dependency here is that there is a notion of "release" for both the operator and operations console.)

@mbwhite mbwhite force-pushed the operator-console-install branch 2 times, most recently from 85033e3 to d5e267a Compare July 20, 2022 13:16
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
@mbwhite mbwhite force-pushed the operator-console-install branch from d5e267a to c9b1d63 Compare July 20, 2022 13:21
@mbwhite mbwhite merged commit e35f657 into IBM-Blockchain:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants