Change session close logic to always attempt to close a lock session even if releasing the lock fails #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondr96
approved these changes
Oct 28, 2021
kramvan1
reviewed
Oct 28, 2021
| if v3l.session != nil { | ||
| serr := v3l.session.Close() | ||
| if err == nil { | ||
| err = serr |
There was a problem hiding this comment.
Since this is a new possible error, I looked at the callers, but only see logging of the error and no action/logic. This should be safe change without other new tests then.
kramvan1
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the session will prevent the lease that the lock key is bound to from being renewed indefinitely.