Add source label to callback duration metric #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rules count to engine logging
kramvan1
changed the title
sonaljain0
approved these changes
Jun 18, 2024
brandondr96
reviewed
Jun 18, 2024
kramvan1
commented
Jun 18, 2024
| @@ -70,7 +70,7 @@ func (w *watcher) singleRun() { | |||
| time.Sleep(delay) // TODO ideally a context should be used for fast shutdown, e.g. select { case <-ctx.Done(); case <-time.After(delay) } | |||
| } | |||
| w.logger.Debug("Calling process key", zap.String("key", key)) | |||
| w.kp.processKey(key, value, w.api, w.logger, map[string]string{}, incRuleProcessedCount) | |||
| w.kp.processKey(key, value, w.api, w.logger, map[string]string{"source": "watcher"}, incRuleProcessedCount) | |||
There was a problem hiding this comment.
Crawler source is already being done here: https://github.com/IBM-Cloud/go-etcd-rules/blob/master/rules/int_crawler.go#L200
brandondr96
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow views into crawler vs watcher initiated callbacks.
Add rules count to engine logging.